Fix code block formatting in lists#11
Open
pfandzelter wants to merge 1 commit intocolorchestra:masterfrom
Open
Fix code block formatting in lists#11pfandzelter wants to merge 1 commit intocolorchestra:masterfrom
pfandzelter wants to merge 1 commit intocolorchestra:masterfrom
Conversation
In colorchestra#7 I added a filter to only apply `code` formatting to inline code within `p` tags, not to standalone code blocks. While that worked and enabled proper syntax highlighting, it removed formatting for inline code in lists (which are `li` elements for ordered lists and `ul` for unordered lists). I don't know of any other places where inline code could appear (headings?) so this should cover everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7 I added a filter to only apply
codeformatting to inline code withinptags, not to standalone code blocks. While that worked and enabled proper syntax highlighting, it removed formatting for inline code in lists (which arelielements for ordered lists andulfor unordered lists).I don't know of any other places where inline code could appear (headings?) so this should cover everything.