Conversation
ale-rt
reviewed
Jun 20, 2024
Member
There was a problem hiding this comment.
This one looks fine to me, and I am now working on a site that uses this branch since quite some time with Plone 5.2 and Python 3.8.
I would like to bring this to Python3.8.
I am a bit shy to approve and merge this one because it removes quite a lot of tests.
Maybe they were broken, as the commit suggests.
For the moment, I will start a plone6 branch based on this PR. Let's see if I can keep the compatibility with all the Plone versions listed in the setup.py and to reset some tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just making a PR from @abosio 's changes.