Skip to content

mark subscriptions as unsubscribed#34

Open
frisi wants to merge 2 commits intomasterfrom
track-unsubscribes-#15
Open

mark subscriptions as unsubscribed#34
frisi wants to merge 2 commits intomasterfrom
track-unsubscribes-#15

Conversation

@frisi
Copy link
Member

@frisi frisi commented Jun 15, 2018

instead of simply deleting them.

this is a major change in how subscriptions are handled and requires
quite a lot of changes.
the benefit is, that we can track unsubscriptions now

  • we know when they happened (date is included in the csv export)
  • we can skip unsubscribed users when re-importing users from an
    external data source

.. ATTENTION:: requires an update of collective.singing too

this fixes #15

frisi added 2 commits June 15, 2018 16:31
instead of simly deleting them.

this is a major change in how subscriptions are handled and requires
quite a lot of changes.
the benefit is, that we can track unsubscriptions now

* we know when they happened (date is included in the csv export)
* we can skip unsubscribed users when re-importing users from an
external data source

.. ATTENTION:: requires an update of collective.singing too

this fixes #15
@frisi
Copy link
Member Author

frisi commented Jun 15, 2018

@dnouri could you please have a look at this one?

i might add handling for the unsubscribed for the xxx sections in browser.subscribe.py (eg

# XXX handle unsubscribed here too?
) and additional tests for them.

before or after merging i'll remove the pin for the collective.singing branch.
i can't run all singing tests via collective.dancing's test-runner (import errors for plone.testing) and i won't have the resources to fix that.
i'd say we're fine when collective.dancing tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notification for unsubscribed addresses

1 participant