Skip to content

fix(Piece): Allow promises to CorePiece objects #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webJose merged 2 commits into from
Dec 18, 2025
Merged

fix(Piece): Allow promises to CorePiece objects #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a64ae4
fix(Piece): Allow promises to CorePiece objects
webJose Dec 18, 2025
a2b58d5
fix(cicd): Change test script for CI/CD
webJose Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
node-version: 24
build-script: build
test-script: test
test-script: test:cicd
npm-tag: ${{ inputs.npm-tag || 'latest' }}
dry-run: ${{ inputs.dry-run || false }}
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ jobs:
with:
node-version: 24
build-script: build
test-script: test
test-script: test:cicd
build: false
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"test:unit": "vitest",
"test": "npm run test:unit -- --run",
"test:cicd": "npx playwright install && npm run test",
"test:e2e": "playwright test"
},
"files": [
Expand All @@ -46,8 +47,8 @@
}
},
"peerDependencies": {
"svelte": "^5.0.0",
"@collagejs/core": "^0.1.0"
"@collagejs/core": "^0.1.2",
"svelte": "^5.0.0"
},
"devDependencies": {
"@playwright/test": "^1.57.0",
Expand Down
4 changes: 2 additions & 2 deletions src/lib/Piece/Piece.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* The `CorePiece` instance to render.
*/
piece: CorePiece<TProps>;
piece: CorePiece<TProps> | Promise<CorePiece<TProps>>;
/**
* Optional HTML attributes to set on the container element that wraps the piece.
*/
Expand All @@ -40,7 +40,7 @@
export function piece<
TProps extends Record<string, any> = Record<string, any>,
>(
piece: CorePiece<TProps>,
piece: CorePiece<TProps> | Promise<CorePiece<TProps>>,
containerProps?: HTMLAttributes<HTMLDivElement>,
) {
return {
Expand Down