Enhance EIP-1271 signature support in SafeTestTools#17
Open
arawrdn wants to merge 2 commits intocolinnielsen:mainfrom
Open
Enhance EIP-1271 signature support in SafeTestTools#17arawrdn wants to merge 2 commits intocolinnielsen:mainfrom
arawrdn wants to merge 2 commits intocolinnielsen:mainfrom
Conversation
Owner
|
hey thanks for contributing. this project does not use hardhat on purpose - can you please update your tests to use foundry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the EIP-1271 signature verification capabilities in SafeTestTools, allowing more flexible and robust testing of contract signatures.
Changes
EIP1271Utils.solhelper library to verify signatures from any contract implementing EIP-1271.eip1271.test.jsto validate signature verification logic with mock contracts.scripts/testEIP1271.jsto demonstrate integration in tests.Why
Currently, SafeTestTools only supports basic EIP-1271 verification. These changes enable developers to:
Test Plan
npx hardhat testto ensure all new tests pass.