Skip to content

Bugfix: Check if ColdboxVirtualApp Exists Before Shutdown #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
homestar9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: Check if ColdboxVirtualApp Exists Before Shutdown #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test-harness/tests/Application.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ component{
}

public void function onRequestEnd( required targetPage ) {
request.coldBoxVirtualApp.shutdown();
if ( request.keyExists( "coldBoxVirtualApp" ) ) {
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space in the keyExists function call. It should be request.keyExists( "coldBoxVirtualApp" ) instead of request.keyExists( "coldBoxVirtualApp" ) to match the project's formatting standards which use single spaces for padding.

Suggested change
if ( request.keyExists( "coldBoxVirtualApp" ) ) {
if ( request.keyExists( "coldBoxVirtualApp" ) ) {

Copilot uses AI. Check for mistakes.
request.coldBoxVirtualApp.shutdown();
}
Comment on lines +78 to +79
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation uses spaces but this project is configured to use tabs for indentation (see .cfformat.json). The if block and its contents should be indented with tabs to match the project's formatting standards.

Suggested change
request.coldBoxVirtualApp.shutdown();
}
request.coldBoxVirtualApp.shutdown();
}

Copilot uses AI. Check for mistakes.
}

private boolean function shouldEnableFullNullSupport() {
Expand Down
Loading