Skip to content

Conversation

@marcelosalloum
Copy link

Description

Adds formal specification documentation for the exact payment scheme on Stellar blockchain, addressing the request in #711.

This spec follows the same structure as existing network-specific scheme documents (EVM, SVM, SUI) and defines how x402 v2 payments work on Stellar using its smart contracts platform. It includes an appendix with Stellar-specific knowledge.

Tests

No code affected

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@cb-heimdall
Copy link

cb-heimdall commented Jan 9, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel
Copy link

vercel bot commented Jan 9, 2026

@marcelosalloum is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the specs Spec changes or additions label Jan 9, 2026
@phdargen
Copy link
Contributor

Thanks a lot for putting this together @marcelosalloum! Notified the core team to review

@phdargen
Copy link
Contributor

@marcelosalloum it is my understanding that you are from the Stellar team, is this correct? If so, was this already internally reviewed? Otherwise, would be great to also get some feedback from the Stellar team on this proposal

@marcelosalloum
Copy link
Author

@phdargen: yep I'm from the Stellar team. We had this reviewed as an internal doc before and I'm also asking my team for another review here in the repo. Thanks.

@phdargen
Copy link
Contributor

@phdargen: yep I'm from the Stellar team. We had this reviewed as an internal doc before and I'm also asking my team for another review here in the repo. Thanks.

Great, thank you!

@quietbits
Copy link

From the perspective of Stellar blockchain features, this schema specification looks good to me.

@jeesunikim
Copy link

The schema with the latest changes looks good to me! Thanks you @marcelosalloum

@marcelosalloum
Copy link
Author

Hey @phdargen, @CarsonRoscoe: we at the Stellar team have completed our internal reviews, and we've incorporated it on the spec proposal. Plz let me know if you have any questions.

I'm marking #711 as draft and will reopen it once the spec is fully synced and merged.

…ndation

1. Remove `maxLedgerOffset` and calculate expiration ledger based on `maxTimeoutSeconds`.
2. Make it clear that facilitator's `/settle` should not assume prior validation and the flow doesn't need to go through `/validate`
3. Add an important check that ensures the simulation emits the expected transfer/balance events
@marcelosalloum marcelosalloum force-pushed the feature/stellar-exact-spec branch from 34f7eee to 4a6ded3 Compare January 16, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specs Spec changes or additions

Development

Successfully merging this pull request may close these issues.

6 participants