Skip to content

Conversation

@sohw400
Copy link

@sohw400 sohw400 commented Dec 23, 2025

Summary

Add comprehensive unit tests for x402/path.py module.

Test Coverage

  • Exact matching: basic, trailing slash, case sensitivity
  • Glob patterns: single/double wildcards, middle wildcards, ? wildcard
  • Regex patterns: basic, digit matching, partial match, groups
  • List patterns: multiple patterns, mixed types, empty list
  • Edge cases: empty strings, root path, special characters, invalid types

Test Results

24 passed

Files Changed

  • python/x402/tests/test_path.py (new)

@vercel
Copy link

vercel bot commented Dec 23, 2025

@sohw400 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link

cb-heimdall commented Dec 23, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@phdargen phdargen self-assigned this Dec 23, 2025
@phdargen
Copy link
Contributor

Hi @sohw400, thanks for the addition!

Now that v2 is out, the legacy packages are effectively frozen and we are closing PRs targeting v1.
Given that the python v2 implementation is still in development, we could still get this in if you'd like but it would be better to directly target the feat/python-v2-sdk development branch, where v1 is moved to /python/legacy, see #841

Closing this now, please target the feat/python-v2-sdk branch if you open a new PR

@phdargen phdargen closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants