This repository was archived by the owner on Jan 15, 2025. It is now read-only.
[AgentKit] Wrap ETH Tool #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
John-peterson-coinbase
left a comment
John-peterson-coinbase
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I left 2 small comments. We will get this merged as soon as those are resolved.
@derekbrown
| }); | ||
|
|
||
| describe("Wrap Eth Action", () => { | ||
| const NETWORK_ID = Coinbase.networks.BaseSepolia; |
John-peterson-coinbase
approved these changes
Jan 12, 2025
Contributor
John-peterson-coinbase
left a comment
John-peterson-coinbase
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution. We will pull this into a package release on Monday!
Contributor
|
@derekbrown - We require all commits to be signed before merging to master. Can you please rebase into a new signed commit following these steps. Thank you! |
derekbrown
force-pushed
the
derek/wrap-eth-tool
branch
from
a93faf4 to
4d38aa6
Compare
Contributor
Author
No worries! Thought I had that configured anyway; thanks for reminding me. Just force-pushed a verified commit – should be good to go now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added a tool to allow agents to wrap a given amount of ETH.
Qualified Impact
Little "bleed-over" impact, but wrapping ETH may not work reliably.