This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Add handlers for s3 URL generation#2
Open
nmorgan-cb wants to merge 4 commits intocoinbase-samples:waas-workshopfrom
Open
Add handlers for s3 URL generation#2nmorgan-cb wants to merge 4 commits intocoinbase-samples:waas-workshopfrom
nmorgan-cb wants to merge 4 commits intocoinbase-samples:waas-workshopfrom
Conversation
rcbgr
suggested changes
Jul 10, 2023
rcbgr
suggested changes
Jul 11, 2023
Contributor
rcbgr
left a comment
rcbgr
left a comment
There was a problem hiding this comment.
Nearly there. Please update the 3P license information file too for the AWS SDK
rcbgr
suggested changes
Jul 24, 2023
config/config.go
Outdated
| AppUrl string `mapstructure:"APP_URL"` | ||
| AwsS3Enabled bool `mapstructure:"AWS_S3_ENABLED"` | ||
| BucketName string `mapstructure:"BUCKET_NAME"` | ||
| PresignedUrlExpiration int64 `mapstructure:"PRESIGNED_URL_EXPIRATION"` |
Contributor
There was a problem hiding this comment.
Add a comment about units or add to var name. Is this ms or sec?
You could do PresignedUrlExpirationInSec or InMs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.