feat: allow the user to customize the http client#41
Merged
Vein05 merged 3 commits intocohesion-org:mainfrom Mar 6, 2025
Merged
feat: allow the user to customize the http client#41Vein05 merged 3 commits intocohesion-org:mainfrom
Vein05 merged 3 commits intocohesion-org:mainfrom
Conversation
Collaborator
|
Thanks for the pr, I will be reviewing it asap. |
Collaborator
|
Just letting you know, some tests are failing on this pr. Did you check them on your local development environment? Please read about how to test our package on https://github.com/cohesion-org/deepseek-go?tab=readme-ov-file#running-tests-1 |
Contributor
Author
|
An error has been fixed. I had executed the command |
Vein05
approved these changes
Mar 6, 2025
Collaborator
|
Thank you. To answer your question on if we need to export those functions is yes as they are used by client and other api related functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
http.Client, not the fixed&http.Client{Timeout: timeout}.If not configuring the http client, use
http.DefaultClientinstead.context.WithTimeoutto support it.Motivation
The user maybe configure the proxy by the user-defined
http.Client.