Skip to content

Conversation

@doctrino
Copy link
Collaborator

@doctrino doctrino commented Dec 14, 2025

Description

Improving the HTTPClient based on learnings

  • Moved console to the __init__ such that it does not have to be passed in with each request.
  • Rewrote all HTTPMessage classes to pydantic format. This reduces the size of those classes in two.
  • Added request_single to the HTTPClient to work with the new HTTPMessage classes.

Too avoid a large PR, I have chosen to build up the new HTTPMessage classes in parallel to the existing code. The plan is as follows

  1. ([CDF-26481] 🤒 Improve HTTPClient #2292 ) Introduce new HTTPMessage classes for generic request and responses.
  2. ([CDF-26481] 🤒 Improve HTTPClient Part 2 #2293), introduce new ItemMessage classes to handle items requests.
  3. ([CDF-26481] 🤒 Improve HTTPClient Part 3 #2294) Replace all calls to the existing request and request_with_retries with the request_single and request_items method. -
  4. ([CDF-26481] 😫 Improve HTTPClient Part 4 #2319) Replace delete calls the existing request_with_retries with the request_single and request_items methods. Note I do this by making identifier objects a RequestResource.
  5. (This PR) Replace the the existing request and request_with_retries with the request_single and request_items method in StorageIO.
  6. Delete the existing HTTPMessage and remove the 2 suffix from the new HTTPMessages.

Bump

  • Patch
  • Skip

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Base automatically changed from request-items-hashable to main December 15, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants