[CDF-26481] 💡 Improve HTTPClient Part 4 #2323
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving the
HTTPClientbased on learningsconsoleto the__init__such that it does not have to be passed in with each request.HTTPMessageclasses to pydantic format. This reduces the size of those classes in two.request_singleto theHTTPClientto work with the newHTTPMessageclasses.Too avoid a large PR, I have chosen to build up the new
HTTPMessageclasses in parallel to the existing code. The plan is as followsHTTPMessageclasses for generic request and responses.ItemMessageclasses to handle items requests.requestandrequest_with_retrieswith therequest_singleandrequest_itemsmethod. -request_with_retrieswith therequest_singleandrequest_itemsmethods. Note I do this by making identifier objects a RequestResource.requestandrequest_with_retrieswith therequest_singleandrequest_itemsmethod in StorageIO.HTTPMessageand remove the2suffix from the newHTTPMessages.Bump