Skip to content

[CDF-25364] 🙃 Raise if parent ID is set #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
doctrino wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CDF-25364] 🙃 Raise if parent ID is set #1811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cognite_toolkit/_cdf_tk/loaders/_resource_loaders/location_loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
LocationFilterWriteList,
)
from cognite_toolkit._cdf_tk.constants import BUILD_FOLDER_ENCODING
from cognite_toolkit._cdf_tk.exceptions import ResourceRetrievalError, ToolkitCycleError
from cognite_toolkit._cdf_tk.exceptions import ResourceRetrievalError, ToolkitCycleError, ToolkitNotSupported
from cognite_toolkit._cdf_tk.loaders._base_loaders import ResourceLoader
from cognite_toolkit._cdf_tk.resource_classes import LocationYAML
from cognite_toolkit._cdf_tk.utils import in_dict, quote_int_value_by_key_in_yaml, safe_read
Expand Down Expand Up @@ -103,6 +103,9 @@ def safe_read(self, filepath: Path | str) -> str:
return quote_int_value_by_key_in_yaml(safe_read(filepath, encoding=BUILD_FOLDER_ENCODING), key="version")

def load_resource(self, resource: dict[str, Any], is_dry_run: bool = False) -> LocationFilterWrite:
if "parentId" in resource:
raise ToolkitNotSupported("The property 'parentId' is not supported. Use 'parentExternalId' instead.")

if parent_external_id := resource.pop("parentExternalId", None):
# This is a workaround: when the parentExternalId cannot be resolved because the parent
# hasn't been created yet, we save it so that we can try again "later"
Expand Down
Loading