Fix inconsistent code style from PR #57 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix switch-case indentation to follow K&R style (align case labels with switch) - Replace EXIT_SUCCESS with 0 in non-exit function argparse_help_cb_no_exit() - EXIT_SUCCESS should only be used with exit() or returned by main() Fixes #74 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the code style inconsistencies introduced in PR #57, as reported in issue #74:
EXIT_SUCCESSwith0inargparse_help_cb_no_exit()function, sinceEXIT_SUCCESSshould only be used withexit()or returned bymain()Changes Made
argparse_options_check()function to follow K&R style used throughout the codebasereturn (EXIT_SUCCESS);toreturn 0;inargparse_help_cb_no_exit()function for proper function return semanticsTest Plan
make test)gcc -Wall -Wextra)Fixes #74
🤖 Generated with Claude Code