Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe project is updated to support ESLint 10 across workflows, dependencies, and documentation. Changes include adding legacy peer-dependencies flags to npm installations, bumping ESLint to version 10, updating Node.js version requirements, and migrating documentation to reflect the new ESLint 10 specifications and requirements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ PR package published successfully! Install: View on npm: https://www.npmjs.com/package/@codfish/eslint-config/v/0.0.0-PR-137--a08438e |
BREAKING CHANGE: ESLint 10 support with updated minimum requirements This is a major version update that upgrades the package from ESLint 9 to ESLint 10. ## Breaking Changes - **ESLint 10 Required**: Minimum ESLint version is now 10.0.0 (was >= 9) - **Node.js v20.19.0+**: Minimum Node.js version increased from v20.0.0 to v20.19.0 - **Peer Dependency**: eslint peer dependency updated from `>= 9` to `>= 10` - **New Default Rules**: Three new rules from eslint:recommended may report new errors: - no-unassigned-vars - Disallow variables that are assigned but never used - no-useless-assignment - Disallow assignments that dont change the value - preserve-caught-error - Enforce that caught errors are not reassigned - **JSX Tracking**: ESLint 10 properly tracks JSX references, which may surface previously hidden unused import warnings in React files ## Updated Dependencies - eslint: ^10.0.0 (peer, was ^9.35.0) - @eslint/js: ^10.0.0 (was ^9.35.0) - typescript-eslint: ^8.54.0 (was ^8.44.0) - @vitest/eslint-plugin: ^1.6.6 (was ^1.3.10) - eslint-plugin-jest: ^29.12.2 (was ^29.0.1) - eslint-plugin-testing-library: ^7.15.4 (was ^7.1.0) - eslint-plugin-yml: ^3.1.2 (was ^3.0.0) - eslint-plugin-prettier: ^5.5.5 (was ^5.5.4) ## Migration Guide Users upgrading to this version need to: 1. Update to Node.js v20.19.0+ (or v22.13.0+, or v24+) 2. Update to ESLint 10: npm install --save-dev eslint@10 3. Install with --legacy-peer-deps until plugin ecosystem updates 4. Review and fix any new linting errors from the new ESLint 10 rules 5. Check React files for newly reported unused imports due to improved JSX tracking See README.md for complete migration instructions. ## Technical Details - Configuration code unchanged (already using flat config format) - All 55 tests passing with ESLint 10 - Self-linting successful - CI/CD workflows updated to use --legacy-peer-deps and explicit Node.js versions - Documentation updated with comprehensive migration guide
012c838 to
a08438e
Compare
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: ESLint 10 support with updated minimum requirements
This is a major version update that upgrades the package from ESLint 9 to ESLint 10.
Breaking Changes
>= 9to>= 10Updated Dependencies
Migration Guide
Users upgrading to this version need to:
npm install --save-dev @codfish/eslint-config@latest eslint@10See README.md for complete migration instructions.
Technical Details
Summary by CodeRabbit
Release Notes
Upgrades
Documentation