This repository was archived by the owner on Jan 16, 2023. It is now read-only.
Add demo example #19
Open
Add demo example #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikmel2803
reviewed
Nov 6, 2019
example/src/styles/player.css
Outdated
| background: var(--color-bg-element); | ||
| box-shadow: 0 1px 1px 0 rgba(0, 0, 0, 0.05); | ||
| padding: 8px 15px; | ||
| font-family: "Roboto"; |
Member
There was a problem hiding this comment.
пропиши лучше один раз в стилях к html
example/src/styles/player.css
Outdated
| border-radius: 3px; | ||
| } | ||
|
|
||
| &::-moz-range-track { |
Member
There was a problem hiding this comment.
общие стили надо вынести (перечислить селекторы через запятую)
Member
Author
There was a problem hiding this comment.
В хроме есть баг, который не позволяет этого сделать. Если писать селекторы через зяпятую, то тогда стили для кастомных селекторов не применяются.
neSpecc
approved these changes
Nov 14, 2019
nikmel2803
suggested changes
Nov 14, 2019
example/src/styles/player.css
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
example/src/styles/base.css
Outdated
| -moz-osx-font-smoothing: grayscale; | ||
| } | ||
|
|
||
| *, *:before, *:after { |
Member
There was a problem hiding this comment.
Suggested change
| *, *:before, *:after { | |
| *, *::before, *::after { |
example/src/styles/base.css
Outdated
| @@ -0,0 +1,28 @@ | |||
| @import "variables.css"; | |||
|
|
|||
| @import url('https://fonts.googleapis.com/css?family=Roboto&display=swap'); | |||
Member
There was a problem hiding this comment.
плохо загружать шрифты таким образом. Надо в head прописать
…codex-team/codex.music into add-demo-example � Conflicts: � example/src/App.vue
nikmel2803
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.