Added success message to the newsletter form#3
Open
akshay0611 wants to merge 1 commit intocodewithsadee:masterfrom
Open
Added success message to the newsletter form#3akshay0611 wants to merge 1 commit intocodewithsadee:masterfrom
akshay0611 wants to merge 1 commit intocodewithsadee:masterfrom
Conversation
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Your JavaScript implementation for filtering and newsletter subscription is well-structured and efficient. The filterBox.setAttribute method dynamically updates the filter attribute, ensuring smooth interactivity. The event listener for the newsletter form prevents default submission, displays a success message, resets the form, and automatically hides the message after four seconds, enhancing user experience. Your code follows best practices, keeping it clean and easy to maintain. For improvement, consider adding animations to the success message for a smoother UX. Overall, this is a solid and functional implementation worth showcasing on GitHub...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the newsletter subscription form by adding a success message that appears upon submission and disappears after 4 seconds. The input field resets after submission, improving user experience.
Changes:
Fixes: #2