Add target top to external links in embed mode #2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow entry type frontend apps to detect whether the entry is being rendered as an embed by reading the embed flag from the request env. REDMINE-21194
Allow scrolled frontend to detect embed mode by reading the embed flag from the seed data config. REDMINE-21194
Allow scrolled frontend to know the URL it was loaded from. This enables opening external links with target _top in embeds. REDMINE-21194
Ensures that clicking external links in embedded entries opens them in the parent frame instead of the embed iframe. Legacy internal links using fragment hrefs are preserved. REDMINE-21194
Move comprehensive link behavior tests to Link-spec.js and simplify EditableLink and EditableText specs to integration smoke tests only. This reduces duplication and ensures link behavior is tested at the source. REDMINE-21194
External links in embed mode now correctly render with target="_top" in server-side rendered content, matching client-side behavior. REDMINE-21194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-21194