Conversation
RESTful routes are a way to implement a conventional and standardized design to server routes that work with resources. In this case, the resources we're working with are `jobs` and `skills`, so the routes that affect those resources should follow RESTful conventions. There are two significant changes in this commit: 1. When working with singular resources, add an identifier to the URL (e.g. DELETE /jobs/21 means "delete job resource with id 21) 2. Let the HTTP verb define the route (e.g. PUT /jobs/21 means "edit job resource with id 21, no need for an extraneous /jobs/edit in the route) Check out http://en.wikipedia.org/wiki/Representational_state_transfer#Applied_to_web_services for more information
Partials don't include the <li> context for skills, which makes them match the structure of how jobs are managed.
Adds a delete button to skills on the résumé show page so that user can remove skills as needed
Since jobs can be edited on the main page, and skills can be created and deleted, making them editable on a separate page seems redundant. So instead there will just be a separate edit page for the user profile information. Now the app has two primary pages: - "/" which points to "/resumes/show" - "/users/edit" This commit also removes the "put /skills/:skill_id" route, as it is no longer in use anywhere.
Reduce smaller functions, add extra comments.
tannerwelsh
added a commit
that referenced
this pull request
Nov 2, 2014
Asynchronously delete skills
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch satisfies the requirements for release 1.3.0:
This release also makes improvements to the underlying architecture of the application, including the following changes:
skills.jsIn addition, the
/resumes/editpage has been changed to/users/editand now contains only a form to edit the user profile. This change removes redundancy in editing other resources.