-
Notifications
You must be signed in to change notification settings - Fork 21
Add sorting of doc_methods on a repo by documentation status #24
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schneems You would know, because you wrote GitHubBub, but I got a NoMethodError on fetch, so I checked the gem's source, and it looked like it's been replaced by get? Was this referencing an older version of the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HA!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's an older API
|
The build failed, but I stashed my changes, and it still failed, so I don't believe the failure is related to my commit. |
5f815e4 to
ec281f8
Compare
|
While I'm waiting, I'll see if I can determine the cause of the failing test. Should be able to look into this in the next day or two. |
|
@thenickcox Looks like the test was failing all the time. d34c68a is the commit that added this test. git checkout d34c68a3
rake test
...
Finished in 14.695983s, 0.2722 runs/s, 0.4763 assertions/s.
1) Failure:
ParsersYardTest#test_parses_threaded [/Users/prathamesh/Projects/sources/docs_doctor/test/parsers/yard_test.rb:13]:
Expected: 29
Actual: 27
2) Failure:
UserTest#test_User#subscribe_docs [/Users/prathamesh/Projects/sources/docs_doctor/test/models/users_test.rb:21]:
"User.find(1).doc_assignments.count" didn't change by 1.
Expected: 1
Actual: 2
4 runs, 7 assertions, 2 failures, 0 errors, 0 skips |
This commit adds sorting on a repo between documented and undocumented methods, via a simple UI. Closes codetriage#21.
ec281f8 to
ef99631
Compare
|
@prathamesh-sonpatki Fixed it. It was an issue with the way I wrote the fixture data. Looks like it's good to merge, should you so desire. |
|
Interesting, what was the difference in fixtures? |
|
@prathamesh-sonpatki I get different output on that commit: $ git checkout d34c68a3
$ rake test
Run options: --seed 36707
# Running:
.Cloning into 'threaded'...
remote: Counting objects: 248, done.
remote: Total 248 (delta 0), reused 0 (delta 0), pack-reused 248
Receiving objects: 100% (248/248), 35.46 KiB | 0 bytes/s, done.
Resolving deltas: 100% (123/123), done.
Checking connectivity... done.
F..
Finished in 2.588068s, 1.5456 runs/s, 2.7047 assertions/s.
1) Failure:
ParsersYardTest#test_parses_threaded [/Users/nick/git/docs_doctor/test/parsers/yard_test.rb:13]:
Expected: 29
Actual: 27
4 runs, 7 assertions, 1 failures, 0 errors, 0 skipsSo I don't actually get a difference in the fixtures. My first commit made the test fail because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I like this style. Very smooth...
I haven't hit #send's guts yet but I love the idea of the params being passed to a method named as such. Nice
This commit adds sorting on a repo between documented and undocumented
methods, via a simple UI.
Closes #21.