This repository was archived by the owner on Sep 11, 2020. It is now read-only.
haleksan/shelter frontend #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiinterfell
reviewed
May 15, 2019
Wiinterfell
left a comment
Wiinterfell
left a comment
There was a problem hiding this comment.
Few minor comments, but overall lgtm 🚀
(I think we don't need to commit package-lock.json as well 🤔 )
|
|
||
| it('should render the given description', () => { | ||
| const { getByText } = render(<PetCard pet={petMock}/>); | ||
| expect(getByText("Fido is a good boy who loves long walks in the park, playing with his ball and licking faces. He's great with children and an absolute sweetheart.")).toBeInTheDocument(); |
There was a problem hiding this comment.
Can we make a const value for the description, so we don't have to write it twice? :)
| render() { | ||
| return ( | ||
| <Card style={{ width: '18rem' }}> | ||
| <Card.Img variant="top" src={"https://source.unsplash.com/collection/212527/200x200/?sig=" + Math.floor(Math.random() * 100)} /> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UI and unit tests for learning purposes.