Skip to content

perf: add bulk insert support for tags #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bug-author wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: add bulk insert support for tags #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9520cda
perf: add bulk insert support for tags
bug-author Nov 17, 2025
584830f
fix: correct placeholder syntax
bug-author Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions internal/contact/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,26 @@ func (r *Repository) GetByEmail(email string) (*Contact, error) {
}

func insertTagIfNotExist(txn *sql.Tx, tags []Tag) error {
// todo: implement bulk inserts here
for _, tag := range tags {
_, err := txn.Exec(`INSERT OR IGNORE INTO tags (text) VALUES (?)`, tag.Text)
if err != nil {
return fmt.Errorf("failed to insert tag: %w", err)
}
if len(tags) == 0 {
return nil
}

placeholders := make([]string, len(tags))
args := make([]interface{}, len(tags))

for i, tag := range tags {
placeholders[i] = "(?)"
args[i] = tag.Text
}

query := fmt.Sprintf(
`INSERT OR IGNORE INTO tags (text) VALUES %s`,
strings.Join(placeholders, ", "),
)

_, err := txn.Exec(query, args...)
if err != nil {
return fmt.Errorf("failed to bulk insert tags: %w", err)
}

return nil
Expand Down