Issue 30 events page #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into issue-30-Events_page Merge branch 'issue-6-Individual_event_pages' into issue-30-Events_page
…uses/game-dev into issue-30-Events_page
laurenpudz
requested changes
Jan 15, 2026
Contributor
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
Looking really really great! Just a few super minor comments. Keep up the great work :)
| return ( | ||
| <> | ||
| <header className="sticky top-0 flex h-24 w-full flex-wrap items-center justify-center rounded-md border-b border-border/20 bg-background px-20 font-jersey10"> | ||
| <header className="sticky top-0 z-50 flex h-24 w-full flex-wrap items-center justify-center rounded-md border-b border-border/20 bg-background px-20 font-jersey10"> |
Contributor
There was a problem hiding this comment.
could you please remove the z-50 here? James will fix it in a separate PR :)
| return ( | ||
| <main className="mx-auto min-h-dvh max-w-6xl px-6 py-16 md:px-20"> | ||
| <h1 className="mb-8 font-jersey10 text-4xl text-primary">Events</h1> | ||
| <p>No events available.</p> |
Contributor
There was a problem hiding this comment.
It would be a good idea to still have the toggle displayed here even if no events are available. This way users can easily flip the toggle to see events instead of having to navigate back to access the toggle
| <div className="flex gap-6 md:gap-10"> | ||
| <div className="relative w-14 flex-shrink-0 md:w-20"> | ||
| <div className="text-2xl font-semibold text-gray-200 md:text-3xl"> | ||
| {year} |
Contributor
There was a problem hiding this comment.
I think this was supposed to be in monospace according to the figma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change Form
Other Information
N/A
Related issue