add tests for PublicViewer support#931
add tests for PublicViewer support#931filariow wants to merge 2 commits intocodeready-toolchain:masterfrom
Conversation
filariow
requested review from
MatousJobanek,
alexeykazakov,
mfrancisc,
rajivnathan,
ranakan19,
sbryzak and
xcoulon
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: filariow The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
|
|
before I do any review of the code itself, I'd like to understand why you want to create a brand new test-suite, why you don't want to incorporate it into the already existing one. |
| oc delete -n ${HOST_NS} pods -l control-plane=controller-manager | ||
| oc delete -n ${HOST_NS} pod -l name=registration-service |
There was a problem hiding this comment.
Nit: What's the difference between oc delete pods (plural) and oc delete pod (singular)? I'd prefer a convention that we stick to.
There was a problem hiding this comment.
a typo 😄 good catch!
| t.Logf("stopping the watch after %s", time.Since(started)) | ||
|
|
||
| require.EqualError(t, err, "unexpected error when reading response body. Please retry. Original error: context deadline exceeded", "The call should be terminated by the context timeout") | ||
| assert.EqualError(t, err, "unexpected error when reading response body. Please retry. Original error: context deadline exceeded", "The call should be terminated by the context timeout") |
There was a problem hiding this comment.
Revert this back, and I think checks will pass:
| assert.EqualError(t, err, "unexpected error when reading response body. Please retry. Original error: context deadline exceeded", "The call should be terminated by the context timeout") | |
| require.EqualError(t, err, "unexpected error when reading response body. Please retry. Original error: context deadline exceeded", "The call should be terminated by the context timeout") |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
linked to: