SANDBOX-1561 | feature: Make targets for debugging services and operators#1251
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MikelAlejoBR The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughAdds a new dev Makefile target to deploy an OpenShift local debug flow that builds debug images and patches operator CSVs to run under the Delve debugger (port 50000); propagates a DEBUG_MODE flag through build/publish scripts and documents the workflow in README.adoc. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/ci/manage-member-operator.sh`:
- Around line 71-74: The --debug-mode option in the argument parsing incorrectly
sets DEBUG_MODE=$1 (capturing the flag string) so push_image's check (which
expects DEBUG_MODE=="true") fails; change the parser to set DEBUG_MODE=true when
encountering -dm|--debug-mode and shift appropriately so downstream logic that
computes DEBUG_MODE_SUFFIX and push_image behave correctly (mirror the
implementation used in manage-host-operator.sh); ensure variables referenced are
DEBUG_MODE, DEBUG_MODE_SUFFIX and the push_image function receive the expected
"true" value.
🧹 Nitpick comments (3)
README.adoc (1)
154-163: Consider noting alternate local ports when debugging multiple components.All three components listen on
:50000; if someone debugs more than one at a time, local port-forwarding will conflict. A short note likeoc port-forward <pod> 50001:50000can prevent confusion.make/test.mk (1)
334-338: GateDEBUG_MODE_PARAMonDEBUG_MODE == trueto avoid accidental debug builds.Right now any non-empty value (including
false) will still pass--debug-mode. If you want a strict boolean, consider checking fortrueexplicitly.🔧 Suggested change
-ifneq (${DEBUG_MODE},"") - ifneq (${DEBUG_MODE},) - $(eval DEBUG_MODE_PARAM = --debug-mode) - endif -endif +ifeq ($(DEBUG_MODE),true) + $(eval DEBUG_MODE_PARAM = --debug-mode) +endif-ifneq (${DEBUG_MODE},"") - ifneq (${DEBUG_MODE},) - $(eval DEBUG_MODE_PARAM = --debug-mode) - endif -endif +ifeq ($(DEBUG_MODE),true) + $(eval DEBUG_MODE_PARAM = --debug-mode) +endifAlso applies to: 348-348, 368-372, 378-378
make/dev.mk (1)
42-79:.ONESHELLaffects all subsequent targets—confirm this global behavior is intended.If you only needed a single shell for
dev-deploy-e2e-local-debug,.ONESHELLwill also change execution semantics of later recipes in this file. If that’s not intended, consider wrapping this recipe in a single-shell block instead of enabling.ONESHELLglobally.
MikelAlejoBR
force-pushed
the
SANDBOX-1561-debug-sandbox-resources-host-op
branch
from
574b517 to
e63d183
Compare
Adds a new Make target which triggers build in the underlying services and operators which end up building the images without any code optimizations and with Delve on them. Once pushed and deployed to the local OpenShift cluster, it patches the host operator, the member operator and the registration service to launch them with the Delve executable, which allows debugging them on port 50000 after port-forwarding to those pods. SANDBOX-1561
MikelAlejoBR
force-pushed
the
SANDBOX-1561-debug-sandbox-resources-host-op
branch
from
e63d183 to
e5db64d
Compare
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Adds a new Make target which triggers build in the underlying services and operators which end up building the images without any code optimizations and with Delve on them.
Once pushed and deployed to the local OpenShift cluster, it patches the host operator, the member operator and the registration service to launch them with the Delve executable, which allows debugging them on port 50000 after port-forwarding to those pods.
Related pull requetss
Jira ticket
[SANDBOX-1561]
Summary by CodeRabbit
New Features
Documentation
Chores