Skip to content

Remove usage of DurationBeforeChangeTierRequestDeletion config#516

Merged
rajivnathan merged 3 commits intocodeready-toolchain:masterfrom
rajivnathan:removeDurationBeforeCTRCmn1
Feb 25, 2026
Merged

Remove usage of DurationBeforeChangeTierRequestDeletion config#516
rajivnathan merged 3 commits intocodeready-toolchain:masterfrom
rajivnathan:removeDurationBeforeCTRCmn1

Conversation

@rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Feb 25, 2026

Related to codeready-toolchain/api#499

Summary by CodeRabbit

  • Chores
    • Simplified internal tier configuration test utilities by removing unused builder method.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7910f and f99be86.

📒 Files selected for processing (1)
  • pkg/test/config/toolchainconfig.go
💤 Files with no reviewable changes (1)
  • pkg/test/config/toolchainconfig.go

Walkthrough

Removed the TiersOption.DurationBeforeChangeTierRequestDeletion builder method from the Tiers option chain in the test configuration toolchain, eliminating the ability to set DurationBeforeChangeTierRequestDeletion values via this configuration option.

Changes

Cohort / File(s) Summary
Test Configuration Builder
pkg/test/config/toolchainconfig.go
Removed TiersOption.DurationBeforeChangeTierRequestDeletion builder method (7 lines deleted).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the DurationBeforeChangeTierRequestDeletion method from the TiersOption builder.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@rajivnathan rajivnathan merged commit 85e4bef into codeready-toolchain:master Feb 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants