Skip to content

update go version#504

Merged
rsoaresd merged 1 commit intocodeready-toolchain:masterfrom
rsoaresd:update_go_version
Jan 8, 2026
Merged

update go version#504
rsoaresd merged 1 commit intocodeready-toolchain:masterfrom
rsoaresd:update_go_version

Conversation

@rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Jan 8, 2026

Description

I noticed that toolchain-e2e, ksctl and wa requires mininum go 1.24.4, so we should align

Summary by CodeRabbit

  • Chores
    • Updated Go language version to the latest patch release for improved stability and compatibility.
    • Updated internal project dependencies to the latest available versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

Walkthrough

This pull request updates the Go module dependencies in go.mod. The Go language version is bumped from 1.24.0 to 1.24.4, and the github.com/codeready-toolchain/api dependency is updated to a newer commit hash.

Changes

Cohort / File(s) Summary
Go Module Updates
go.mod
Bumped Go version from 1.24.0 to 1.24.4 and updated github.com/codeready-toolchain/api dependency from v0.0.0-20260108101803-54d23a1b4f3c to v0.0.0-20260108115150-4c6695ed18de

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • alexeykazakov
  • xcoulon
  • metlos

Poem

🐰 A hop and a bump, versions spring free,
From 1.24.0 to versions four and three,
Dependencies dance, new commits appear,
The toolchain API shines bright and clear! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update go version' is vague and does not specify which version or what the actual change is; it lacks the concrete detail (Go 1.24.0 to 1.24.4) that would make it meaningful for repository history. Revise the title to be more specific, such as 'Bump Go version from 1.24.0 to 1.24.4' or 'Update Go toolchain to 1.24.4 for compatibility'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94ad63d and 4c7cfba.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: GolangCI Lint
  • GitHub Check: Verify Dependencies
  • GitHub Check: Test with Coverage
🔇 Additional comments (3)
go.mod (3)

1-41: LGTM on the overall approach and structure.

The changes look reasonable:

  • Go language version is updated to 1.24.4 per the PR objective
  • The toolchain version (1.24.11) is appropriately newer, allowing use of a more recent toolchain while maintaining the minimum language version requirement
  • The codeready-toolchain/api dependency is updated to a newer commit from the same day
  • No unnecessary dependency churn—all other packages remain at their current versions

Once the two verifications above confirm Go 1.24.4 validity and the api dependency compatibility, this should be good to merge.


3-3: Go 1.24.4 is a valid official release, available for use. The version update is appropriate.


29-29: No action required—the codeready-toolchain/api dependency update is valid.

The dependency update to v0.0.0-20260108115150-4c6695ed18de is part of a coordinated Go version upgrade and has proper checksums. CI workflows for dependency verification and vulnerability checking are in place.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.46%. Comparing base (94ad63d) to head (4c7cfba).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files          53       53           
  Lines        2210     2210           
=======================================
  Hits         1734     1734           
  Misses        413      413           
  Partials       63       63           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rsoaresd
Copy link
Contributor Author

rsoaresd commented Jan 8, 2026

verify-dependencies is expected to fail since it is replacing the api in all other repos without the accompanying changes in each repo since they were not yet merged

@rsoaresd rsoaresd merged commit 9d154db into codeready-toolchain:master Jan 8, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants