KUBESAW-174: Print error output for repos where verification failed#450
Merged
fbm3307 merged 16 commits intocodeready-toolchain:masterfrom Jan 31, 2025
Merged
KUBESAW-174: Print error output for repos where verification failed#450fbm3307 merged 16 commits intocodeready-toolchain:masterfrom
fbm3307 merged 16 commits intocodeready-toolchain:masterfrom
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
alexeykazakov,
mfrancisc,
rajivnathan,
ranakan19 and
xcoulon
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 78.47% 78.47%
=======================================
Files 49 49
Lines 2471 2471
=======================================
Hits 1939 1939
Misses 478 478
Partials 54 54 |
metlos
reviewed
Jan 21, 2025
Contributor
metlos
left a comment
metlos
left a comment
There was a problem hiding this comment.
Looks good. Only a couple of comments below..
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
MatousJobanek
approved these changes
Jan 31, 2025
Contributor
MatousJobanek
left a comment
MatousJobanek
left a comment
There was a problem hiding this comment.
Looks good, thanks for addressing my comments
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to update the verify dependency script such a way that it prints the error/failure in an understandable way
Similar PR