fix: use go version from scanned project#169
fix: use go version from scanned project#169mfrancisc merged 22 commits intocodeready-toolchain:masterfrom
Conversation
WalkthroughModified entrypoint.sh to dynamically resolve GOTOOLCHAIN from the scanned go.mod file instead of using a static value. The script now reads both toolchain and go version directives, preferring toolchain if present, otherwise falling back to go version or defaulting to auto. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
govulncheck-action/entrypoint.sh (1)
23-23:⚠️ Potential issue | 🔴 CriticalTypo:
govulncheckxshould begovulncheck.The command name has an extra
xcharacter, which will cause the script to fail with "command not found" on every invocation.🐛 Proposed fix
-govulncheckx "$@" +govulncheck "$@"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@govulncheck-action/entrypoint.sh` at line 23, The script calls a non-existent command name "govulncheckx" in entrypoint.sh; replace the invocation govulncheckx "$@" with the correct command govulncheck "$@" so the script executes the intended tool, and verify the entrypoint still forwards all args (the "$@" usage should remain unchanged).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@govulncheck-action/entrypoint.sh`:
- Line 23: The script calls a non-existent command name "govulncheckx" in
entrypoint.sh; replace the invocation govulncheckx "$@" with the correct command
govulncheck "$@" so the script executes the intended tool, and verify the
entrypoint still forwards all args (the "$@" usage should remain unchanged).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 96db2f42-e567-44ef-8458-077a5f426847
📒 Files selected for processing (1)
govulncheck-action/entrypoint.sh



wrt https://redhat-internal.slack.com/archives/CHK0J6HT6/p1773222007541979
Summary by CodeRabbit
Release Notes
Bug Fixes
Refactor