govulncheck: use golang:1.24 as a base image#166
govulncheck: use golang:1.24 as a base image#166xcoulon merged 2 commits intocodeready-toolchain:masterfrom
Conversation
all active repositories have migrated to Go 1.24 also, local build is now called `govulncheckx` to distinguish from the official `govulncheck` Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
WalkthroughThe PR updates the Go base image in the Containerfile from 1.23.0 to 1.24.0 and simplifies the makefile by renaming the binary output to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
govulncheck-action/Containerfile (1)
15-19:⚠️ Potential issue | 🔴 CriticalChange the base image tag from
golang:1.24.0togolang:1.24.12(orgolang:1.24)—the1.24.0tag does not exist.The
golang:1.24.0tag is not available on Docker Hub; as of January 2026, the latest patch in the 1.24 line is1.24.12. This will cause the Docker build to fail when pulling the base image. Usegolang:1.24.12or the floating taggolang:1.24instead.Also update the stale comment on line 18 that references Go 1.23.0:
Suggested fix
-FROM golang:1.24.0 +FROM golang:1.24.12 # using a fresh golang image without the `WORKDIR` from the builder stage # see https://docs.github.com/en/actions/reference/workflows-and-actions/dockerfile-support#workdir -# using golang 1.23.0 since most of our projects are still using it (and toolchain will not downgrade the version of go) +# using golang 1.24.12 since most of our projects are now using it (and toolchain will not downgrade the version of Go)
the |
all active repositories have migrated to Go 1.24
also, local build is now called
govulncheckxto distinguish from the officialgovulncheckSigned-off-by: Xavier Coulon xcoulon@redhat.com
Summary by CodeRabbit
govulnchecktogovulncheckx✏️ Tip: You can customize this high-level summary in your review settings.