govulncheck: dump the output of the scan when 'debug' is enabled#162
govulncheck: dump the output of the scan when 'debug' is enabled#162xcoulon merged 2 commits intocodeready-toolchain:masterfrom
Conversation
makes more sense than listing the files :) Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
WalkthroughRefactored debug logging in the scan function by removing directory file enumeration logging and replacing it with full govulncheck process output logging upon completion. This simplifies the control flow while maintaining debugging visibility. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
govulncheck-action/internal/govulncheck/scan.go (1)
54-56: Debug logging of full govulncheck stdout matches the PR goalThis neatly satisfies the intent to dump the scan output when debug is enabled: it runs only after a successful
govulncheckexecution and is gated on the debug level, so normal runs are unaffected. The only thing to keep in mind operationally is that the JSON output can be quite large and may contain detailed vulnerability data, so ensure your log retention/access policies are appropriate for debug logs in CI.
makes more sense than listing the files :)
Signed-off-by: Xavier Coulon xcoulon@redhat.com
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.