SANDBOX-1357: update operator-sdk and operator-registry#151
Conversation
WalkthroughUpdated default versions in prepare-tools GitHub Action: operator-sdk from v1.39.2 to v1.40.0 and operator-registry from v1.49.0 to v1.55.0. Adjusted an inline comment to reference v1.40.0/go.mod. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
prepare-tools-action/action.yml (2)
7-7: Bump to operator-sdk v1.40.0 looks correct; please confirm target vs latest.v1.40.0 is a valid SDK release and aligns with docs; note that v1.41.x is currently the latest, so confirm v1.40.0 is intentional for 4.19. Also, the existing GPG key workflow (052996E2A20B5C7E via keyserver.ubuntu.com) remains the documented path. (github.com, sdk.operatorframework.io)
Optional: make the binary name arch-aware to support non-amd64 runners.
- curl -L -s https://github.com/operator-framework/operator-sdk/releases/download/${{ inputs.operator-sdk-version }}/operator-sdk_linux_amd64 -o operator-sdk \ + OS=linux; ARCH=${{ runner.arch == 'ARM64' && 'arm64' || 'amd64' }} + curl -L -s https://github.com/operator-framework/operator-sdk/releases/download/${{ inputs.operator-sdk-version }}/operator-sdk_${OS}_${ARCH} -o operator-sdk \
11-12: opm v1.55.0 default matches SDK 1.40 guidance; tweak the reference and consider integrity check.SDK 1.40.0 upgrade notes explicitly bump OPM to v1.55.0, and the v1.55.0 tag exists. Suggest pointing to the upgrade doc (stable) instead of a line-anchored go.mod URL. (sdk.operatorframework.io, github.com)
Apply:
- # see https://github.com/operator-framework/operator-sdk/blob/v1.40.0/go.mod#L20 + # see https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/Optional: add a minimal integrity check after download (there’s no signed checksum published for opm); at least assert ELF and expected version string:
curl -Lo opm https://github.com/operator-framework/operator-registry/releases/download/${{ inputs.operator-registry }}/linux-amd64-opm chmod +x opm \ && sudo cp opm /bin/opm \ - && rm opm \ - && opm version + && file /bin/opm | grep -q 'ELF 64-bit' \ + && opm version | grep -q '${{ inputs.operator-registry }}' \ + && rm opm \ + && opm versionConfirm linux-amd64-opm asset naming remains consistent for v1.55.0 (docs show ${OS}-${ARCH}-opm pattern for this series). (sdk.operatorframework.io)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
prepare-tools-action/action.yml(1 hunks)
3 participants
Description
Related PRs
Issue ticket number and link
SANDBOX-1357
Summary by CodeRabbit
Chores
Documentation