build: split GH Action jobs for govulncheck-action#148
Open
build: split GH Action jobs for govulncheck-action#148
Conversation
also, rename for better clarity Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
alexeykazakov
approved these changes
Jul 2, 2025
MatousJobanek
approved these changes
Jul 11, 2025
Comment on lines
+44
to
54
| lint: | ||
| runs-on: ubuntu-latest | ||
| name: Lint govulncheck-action | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Lint | ||
| uses: golangci/golangci-lint-action@v8 | ||
| with: |
Collaborator
There was a problem hiding this comment.
does the linter run fine without having go installed? Just asking because this is what we do in other repos - we install go and then run the linter - eg: https://github.com/codeready-toolchain/sandboxctl/blob/5569f6cb18cf34bdff47fefcd236ca5cbcd73662/.github/workflows/test.yaml#L44-L63
Contributor
Author
There was a problem hiding this comment.
so I guess we could skip the installation of Go in other places, indeed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also, rename for better clarity