KUBESAW-230: add test gh action for pairing mechanism#140
Open
rsoaresd wants to merge 4 commits intocodeready-toolchain:masterfrom
Open
KUBESAW-230: add test gh action for pairing mechanism#140rsoaresd wants to merge 4 commits intocodeready-toolchain:masterfrom
rsoaresd wants to merge 4 commits intocodeready-toolchain:masterfrom
Conversation
rsoaresd
requested review from
MatousJobanek,
alexeykazakov,
drpaneas,
fbm3307,
jrosental,
metlos,
mfrancisc,
rajivnathan and
xcoulon
as code owners
Collaborator
MatousJobanek
left a comment
MatousJobanek
left a comment
There was a problem hiding this comment.
I think that the pairing/build/_output/bin/pairing file shouldn't be included, I guess that you need to update the .gitignore file
xcoulon
reviewed
Jun 5, 2025
Contributor
xcoulon
left a comment
xcoulon
left a comment
There was a problem hiding this comment.
as discussed with @MatousJobanek, let's keep the makefiles in the pairing folder. Other actions written in Go will have their own makefiles (we can revisit that in the future)
Contributor
Author
|
Thanks, @xcoulon @MatousJobanek! Addressed in 2e5ff2f |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to test the unit tests of the new pairing mechanism in PR #135, we need first to merge the test gh action
Issue ticket number and link
KUBESAW-230