Nudge synthesis agent to make use of search tools#271
Nudge synthesis agent to make use of search tools#271alexeykazakov merged 5 commits intocodeready-toolchain:masterfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe synthesis agent's custom instructions were extended to instruct the agent to use an internet search tool to gather the latest information related to alerts; unit and end-to-end expected prompt fixtures were updated to require the new "internet search" concept in the instructions. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/tarsy/agents/synthesis_agent.py (1)
52-84:⚠️ Potential issue | 🟠 Major
mcp_servers()returns an empty list, butcustom_instructions()instructs the agent to use "the internet search tool".The agent is configured to have no MCP servers (line 62 returns
[]; line 57 states "doesn't need tools"), yet the final instruction (line 84) tells the LLM to "Use the internet search tool." Per the coding guidelines, agents are restricted to their assigned MCP server subset during tool validation—the agent won't have access to any search tool at runtime, making this instruction unexecutable and likely to cause LLM hallucinations or confusion.Either:
- Add a search-capable MCP server to
mcp_servers()and update the docstring, or- Remove the internet search instruction since synthesis is pure analysis of parallel investigation results.
🧹 Nitpick comments (1)
backend/tests/unit/config/test_synthesis_agent_config.py (1)
117-128: Test validates "internet search" concept but doesn't verify the agent can actually perform searches.The test confirms the instructions mention "internet search," but given that
mcp_servers()returns[], there's no test verifying the agent actually has access to a search tool. Consider adding a test that validates the agent'smcp_servers()includes a search server if the intent is for the agent to use one — otherwise this test is enshrining a broken contract.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 83.74% 83.71% -0.04%
==========================================
Files 143 143
Lines 13543 13543
==========================================
- Hits 11342 11337 -5
- Misses 2201 2206 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d38c387
into
codeready-toolchain:master
Nudge synthesis agent to make use of search tools to help with getting the latest context
Summary by CodeRabbit
New Features
Tests