feat: add Public-Viewer support#443
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 81.14% 81.89% +0.75%
==========================================
Files 42 42
Lines 2630 2707 +77
==========================================
+ Hits 2134 2217 +83
+ Misses 408 404 -4
+ Partials 88 86 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest |
Signed-off-by: Francesco Ilario <filario@redhat.com>
This commit adds the notion of Public-Viewer to the Proxy as described in [JIRA ASC-532](https://issues.redhat.com/browse/ASC-532). Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
28896b4 to
e360c1f
Compare
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
alexeykazakov
left a comment
There was a problem hiding this comment.
It's a big PR. I only half way through it :)
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
I've worked on some of them. I could not find an easy fix for the others. AFAIUI, they are happening because the same check was already performed by another function in the chain, like retrieving two times the UserSignup or Space info. I tried refactoring but it was requiring too many changes. Maybe we can refactor later in another PR. WDYT? |
Yes, sure. As I said let's do it if it's not too tricky. Otherwise it's OK to leave it as is. |
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
mfrancisc
left a comment
There was a problem hiding this comment.
Great Job 🚀 🏅
Thanks for the additional improvements/tests and for addressing my comments.
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
|
/retest |
Signed-off-by: Francesco Ilario <filario@redhat.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



This PR adds support for Public-Viewer into
proxyas described in JIRA ASC-532Supersedes #417
Linked to: codeready-toolchain/toolchain-e2e#1009
Splitting in multiple PRs: