Remove usage of DurationBeforeChangeTierRequestDeletion config

[rajivnathan]

Related to codeready-toolchain/api#499

Summary by CodeRabbit

• Refactor
  • Removed a public configuration method and related test coverage.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3c07b92 and 6a254fe.

📒 Files selected for processing (2)

• controllers/toolchainconfig/configuration.go
• controllers/toolchainconfig/configuration_test.go

💤 Files with no reviewable changes (2)

• controllers/toolchainconfig/configuration.go
• controllers/toolchainconfig/configuration_test.go

---

Walkthrough

A public method DurationBeforeChangeTierRequestDeletion() from the TiersConfig type and its corresponding test cases are removed from the configuration module. The method previously returned a parsed duration value with a 24-hour default.

Changes

Cohort / File(s)	Summary
Method and Test Removal controllers/toolchainconfig/configuration.go, controllers/toolchainconfig/configuration_test.go	Removed the public TiersConfig.DurationBeforeChangeTierRequestDeletion() method that parsed duration configuration and associated test cases validating default and custom duration values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the DurationBeforeChangeTierRequestDeletion configuration method and its tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment