-
Notifications
You must be signed in to change notification settings - Fork 70
Split test-with-coverage.yml workflow in two pieces: ci-pr (untrusted… #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrosental
merged 11 commits into
codeready-toolchain:master
from
jrosental:split-test-with-coverage-ci-workflow
Feb 5, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
57efb96
Split test-with-coverage.yml workflow in two pieces: ci-pr (untrusted…
jrosental 9fbfc40
Changing actions/upload-artifact to v6.
jrosental 3b45ae6
Add github-token parameter to download artifact step
jrosental 8f8944b
Update coverage.txt path
jrosental b6df27c
fix name of workflow
jrosental 996affd
change name of workflow
jrosental 425d194
fix typo in upload path to codecov
jrosental 182ee22
Change path for uploading coverage.txt artifact
jrosental 48feb6c
Add flags: unittests option
jrosental 389bc30
Remove trailing spaces
jrosental badc443
bump download-artifact action version to v7
jrosental File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,38 @@ | ||
| name: ci-build | ||
| name: test-with-coverage | ||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
| push: | ||
| branches: | ||
| - master | ||
| tags-ignore: | ||
| - '*.*' | ||
| pull_request_target: | ||
| types: [ opened, synchronize, reopened, ready_for_review ] | ||
| branches: | ||
| - master | ||
| - '*.*' | ||
|
|
||
| jobs: | ||
| test-with-coverage: | ||
| name: Test with Coverage | ||
| test: | ||
| runs-on: ubuntu-24.04 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| fetch-depth: 0 | ||
| - name: Checkout PR code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod | ||
| - name: Install Go | ||
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: generate | ||
| run: | | ||
| make generate | ||
| - name: generate | ||
| run: | | ||
| make generate | ||
|
|
||
| - name: Test | ||
| run: | | ||
| make test-with-coverage | ||
| - name: Test | ||
| run: | | ||
| make test-with-coverage | ||
|
|
||
| - name: Upload code coverage | ||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: ./build/_output/coverage/coverage.txt | ||
| flags: unittests # optional | ||
| fail_ci_if_error: true # optional (default = false) | ||
| verbose: true # optional (default = false) | ||
| - name: Upload coverage artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage | ||
| path: ./build/_output/coverage/coverage.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: upload-coverage | ||
| on: | ||
| workflow_run: | ||
| workflows: [ test-with-coverage ] | ||
| types: [ completed ] | ||
|
|
||
| jobs: | ||
| upload-coverage: | ||
| if: > | ||
| github.event.workflow_run.conclusion == 'success' | ||
| runs-on: ubuntu-24.04 | ||
|
|
||
| steps: | ||
| - name: Download coverage artifact | ||
| uses: actions/download-artifact@v7 | ||
| with: | ||
| name: coverage | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| run-id: ${{ github.event.workflow_run.id }} | ||
|
|
||
| - name: Upload to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| # The 'files' attribute consists of 'coverage/coverage.txt'. | ||
| # The 'coverage' directory is created upon the download of the coverage artifact from previous step (it creates a directory with the name of the artifact). | ||
| files: coverage/coverage.txt | ||
| flags: unittests # optional | ||
| fail_ci_if_error: true | ||
| verbose: true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeready-toolchain/registration-service@468f6e9