configure the field owner for the toolchainclusterresources controller that now uses SSA#1215
Conversation
…r that now uses SSA
WalkthroughAdded a FieldManager setting to the ToolchainClusterResources reconciler in Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Main as cmd/main.go
participant Manager as Controller Manager
participant Reconciler as ToolchainClusterResources.Reconciler
note right of Main `#DDEEFF`: during manager setup
Main->>Manager: create manager
Manager->>Reconciler: instantiate reconciler config
Reconciler-->>Manager: config includes FieldManager = constants.HostOperatorFieldManager
note right of Reconciler `#E6F7E6`: reconciler will use FieldManager when applying resources
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, metlos, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We also need a corresponding PR in member-operator https://github.com/codeready-toolchain/member-operator/blob/0d1ea44f4f94ff196b73d34d967e8d2043b3125d/cmd/main.go#L226-L230 |
* Update RQ for base1ns namespace * Add limits and update base template too
) Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
- Coverage 70.12% 70.11% -0.02%
==========================================
Files 84 84
Lines 6561 6561
==========================================
- Hits 4601 4600 -1
- Misses 1748 1749 +1
Partials 212 212 🚀 New features to boost your workflow:
|




The replacement in the
go.modis only temporary until the PR intoolchain-commonis merged.Related PRs:
Summary by CodeRabbit
Configuration
Chores
✏️ Tip: You can customize this high-level summary in your review settings.