feat: manage ready condition in NSTemplatetier

[mfrancisc]

This PR adds/updates the Ready condition in the NSTemplateTier.

depends on: codeready-toolchain/api#465

jira: https://issues.redhat.com/browse/KUBESAW-251

[fbm3307]

Great work , just some minor suggestions/questions.

[fbm3307]

Looks Good,
just good to have , for code readability

[mfrancisc]

/retest

flaky subspace test : https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/codeready-toolchain_host-operator/1149/pull-ci-codeready-toolchain-host-operator-master-e2e/1896912619076325376/build-log.txt

looking at it

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,fbm3307,metlos,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfrancisc]

it looks like we might have a flaky unit test also:

     metric.go:40: 
            	Error Trace:	/home/runner/go/pkg/mod/github.com/codeready-toolchain/toolchain-common@v0.0.0-20250303095208-d379ee86d136/pkg/test/metrics/metric.go:40
            	            				/home/runner/work/host-operator/host-operator/controllers/usersignup/usersignup_controller_test.go:4907
            	Error:      	Not equal: 
            	            	expected: 0xd
            	            	actual  : 0xc
            	Test:       	TestRecordProvisionTime/should_be_in_histogram

will take a look at it as well.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fbm3307]

it looks like we might have a flaky unit test also:

     metric.go:40: 
            	Error Trace:	/home/runner/go/pkg/mod/github.com/codeready-toolchain/toolchain-common@v0.0.0-20250303095208-d379ee86d136/pkg/test/metrics/metric.go:40
            	            				/home/runner/work/host-operator/host-operator/controllers/usersignup/usersignup_controller_test.go:4907
            	Error:      	Not equal: 
            	            	expected: 0xd
            	            	actual  : 0xc
            	Test:       	TestRecordProvisionTime/should_be_in_histogram

will take a look at it as well.

@mfrancisc , its because it checks the sequence too... Probably using assert.elementsmatch should work rather than require.equal

[mfrancisc]

Not sure I'm following.

TBH to me it seems that the bucket nr 13 had 12 as value. So basically it expected 13 but it got 12. Which seems like a timing issue when using the prometheus client.

To me the only way to make the tests 100% reproducible would be to create a mock/stub instead of using the prometheus library. Thus the test would only assert that expected function were called with expected values.

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (a7713fb) to head (5e18a51).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...ollers/nstemplatetier/nstemplatetier_controller.go	69.23%	9 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   79.71%   79.67%   -0.05%     
==========================================
  Files          82       82              
  Lines        8203     8245      +42     
==========================================
+ Hits         6539     6569      +30     
- Misses       1471     1480       +9     
- Partials      193      196       +3     

Files with missing lines	Coverage Δ
test/nstemplatetier/assertion.go	100.00% <100.00%> (ø)
...ollers/nstemplatetier/nstemplatetier_controller.go	76.70% <69.23%> (-2.44%)	⬇️