SANDBOX-1067 | fix: button is incorrectly disabled and style changes#47
Conversation
There was a bug which made the "reset workspaces" button to be disabled when the user was completely provisioned. It was due to a boolean variable that should have been flipped, as it was disabling the button when the user was ready, instead of doing it when it was NOT ready. This commit also includes some style changes requested by the UX team. SANDBOX-1067
WalkthroughA single component file is modified to invert logic conditions for when the "Reset workspaces" action is selectable and its secondary message is visible, swap button variant styles, wrap an alert element in a Box component, and adjust text formatting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mfrancisc
left a comment
There was a problem hiding this comment.
Looks good 👍
Just wondering why it wasn't cought by the unit test ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc, MikelAlejoBR The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2d693a4
into
codeready-toolchain:master
There was a bug which made the "reset workspaces" button to be disabled when the user was completely provisioned. It was due to a boolean variable that should have been flipped, as it was disabling the button when the user was ready, instead of doing it when it was NOT ready.
This commit also includes some style changes requested by the UX team.
Jira ticket
[SANDBOX-1067]
Summary by CodeRabbit
Bug Fixes
Style