Skip to content

add request-received-time annotation key #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatousJobanek merged 3 commits into from
Feb 27, 2025
Merged

add request-received-time annotation key #464

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e2aa7c
add request-received-time annotation key
MatousJobanek Feb 25, 2025
345bb54
comment
MatousJobanek Feb 25, 2025
2aa06e3
Merge branch 'master' into request-received-time-annotation
fbm3307 Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v1alpha1/usersignup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ const (
// UserSignupCaptchaAnnotatedAssessmentAnnotationKey is set if the last captcha assessment for the user was annotated as fraudulent or legitimate
UserSignupCaptchaAnnotatedAssessmentAnnotationKey = LabelKeyPrefix + "captcha-annotated-assessment"

// UserSignupRequestReceivedTimeAnnotationKey is used for the timestamp when the request to create/reactivate UserSignup was received
// The time is stored in time.RFC3339 format, the reason is that the main purpose of the metric is to track the UX of the users, and milliseconds don't really matter in that case
UserSignupRequestReceivedTimeAnnotationKey = LabelKeyPrefix + "request-received-time"

// UserSignupUserEmailHashLabelKey is used for the usersignup email hash label key
UserSignupUserEmailHashLabelKey = LabelKeyPrefix + "email-hash"
// UserSignupUserPhoneHashLabelKey is used for the usersignup phone hash label key
Expand Down
Loading