Skip to content

chore: upgrade to VS Code 1.106 / Electron 37 / Node 22#848

Merged
EhabY merged 4 commits intomainfrom
chore/upgrade-dependencies
Mar 24, 2026
Merged

chore: upgrade to VS Code 1.106 / Electron 37 / Node 22#848
EhabY merged 4 commits intomainfrom
chore/upgrade-dependencies

Conversation

@EhabY
Copy link
Copy Markdown
Collaborator

@EhabY EhabY commented Mar 18, 2026

Breaking: Minimum VS Code version bumped from 1.95 to 1.106 (Electron 32 → 37, Node 20 → 22).

Platform & Tooling

  • Upgrade all Node/TypeScript tooling to match Electron 37 (Node 22): @tsconfig/node22, @types/node@^22, @types/vscode@1.106.0, esbuild target node22, lib ES2024
  • Pin electron devDependency to 37.7.0 (matches VS Code 1.106 runtime exactly)
  • Bump pnpm/action-setup from v4 to v5 in all CI workflows

Dependency Updates

  • Update all dependencies via pnpm update + pnpm dedupe
  • Notable major bumps: @eslint-react/eslint-plugin 2.x → 3.x, jsdom 28 → 29
  • Minor/patch bumps: eslint, typescript-eslint, vitest, vite, ws, @tanstack/react-query, memfs, and others
  • Remove redundant getSessionToken() override in CoderApi (base class now provides identical implementation, and noImplicitOverride flags it)

Workarounds Removed

  • --experimental-require-module flag in test-electron.sh (native in Node 22)
  • Simplified pnpm test to a single vitest invocation instead of two sequential processes
  • pnpm test:webview now runs in Electron (consistent with test:extension)

CI Changes

  • Electron matrix minimum: 32 → 37
  • VS Code integration test minimum: 1.95.0 → 1.106.0
  • Removed @types/vscode from dependabot ignore list (now exact-pinned)

Release Pipeline

  • Release tags (v*) now verify the tagged commit is on main via git merge-base --is-ancestor
  • Pre-release tags (v*-pre) can be pushed from any branch
  • Added fetch-depth: 0 to release checkout for ancestry check

Documentation

  • Updated CONTRIBUTING.md: version table, test runner descriptions, releasing instructions (stable vs pre-release), and a note to run pnpm dedupe after pnpm update

@EhabY EhabY self-assigned this Mar 18, 2026
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch 2 times, most recently from 13b55fb to 8699d47 Compare March 19, 2026 11:51
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch from 8699d47 to 782443d Compare March 19, 2026 12:02
- Pin electron and vscode to exact versions to stop Dependabot
churn; CI tests minimum (Electron 32) and latest via npx separately
- Split CI into extension tests (Electron matrix) and webview
  tests (own job) since Electron's patched fs.readFileSync
  crashes vitest's forks pool with jsdom
- Add version mapping reference (ewanharris/vscode-versions)
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch from 782443d to cdb8f94 Compare March 19, 2026 12:03
@EhabY EhabY changed the title Upgrade dependencies chore: upgrade to VS Code 1.106 / Electron 35 / Node 22 Mar 19, 2026
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch from ffc1309 to 8f1598c Compare March 19, 2026 14:34
- Bump engines.vscode to ^1.106.0, engines.node to >= 22
- Update @types/vscode to 1.106.0 (adds SecretStorage.keys())
- Switch to @tsconfig/node22, target node22 in esbuild, lib ES2024
- Unify CI test jobs into single Electron run, simplify pnpm test
- Remove --experimental-require-module workaround (native in Node 22)
- Run webview tests in Electron alongside extension tests
- Restrict release pipeline to tags on main, document pre-release flow
- Update CONTRIBUTING.md release instructions and version table
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch from 8f1598c to 5f71b99 Compare March 19, 2026 14:38
@EhabY EhabY changed the title chore: upgrade to VS Code 1.106 / Electron 35 / Node 22 chore: upgrade to VS Code 1.106 / Electron 37 / Node 22 Mar 19, 2026
@EhabY EhabY force-pushed the chore/upgrade-dependencies branch from de66cc1 to 79ccc0d Compare March 24, 2026 15:14
@EhabY EhabY merged commit b518e39 into main Mar 24, 2026
7 checks passed
@EhabY EhabY deleted the chore/upgrade-dependencies branch March 24, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants