Skip to content

Improve workspace update confirmation to clarify restart consequence #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EhabY merged 2 commits into from
Feb 12, 2026
Merged

Improve workspace update confirmation to clarify restart consequence #792

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46ec74
Improve workspace update confirmation to clarify restart consequence
EhabY Feb 11, 2026
9f3f6a7
Restore old message
EhabY Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,11 +596,11 @@ export class Commands {
{
useCustom: true,
modal: true,
detail: `Update ${createWorkspaceIdentifier(this.workspace)} to the latest version?\n\nUpdating will restart your workspace which stops any running processes and may result in the loss of unsaved work.`,
detail: `Updating ${createWorkspaceIdentifier(this.workspace)} to the latest template version will restart your workspace. Running processes will be stopped and unsaved work may be lost.`,
Copy link
Copy Markdown
Member

@matifali matifali Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the line break as it was, making it look cleaner.

Copy link
Copy Markdown
Collaborator Author

@EhabY EhabY Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose with the same (old) message then? So essentially we just change the action to indicate the restart (not ignorable)

Copy link
Copy Markdown
Member

@matifali matifali Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think. That sounds good to me. Is it possible to make the button red, orange, or yellow?

Copy link
Copy Markdown
Collaborator Author

@EhabY EhabY Feb 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no, we cannot change this. Even they use info for deleting files (with the same 'ol themed button):

image

Copy link
Copy Markdown
Member

@matifali matifali Feb 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it's better to reprompt, people tend to skim and not read the whole thing

Can we add another prompt?
I don't think renaming the button alone solves the pain point.

Copy link
Copy Markdown
Collaborator Author

@EhabY EhabY Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do a follow up prompt yes, but see this comment: #784 (comment)

Essentially it would be a 3-step process instead of 2:

  1. Click "Update Workspace" on the statusbar OR Click "Update" on the notification OR execute "Update Workspace" command from the palette
  2. Get the modal above (currently we stop here)
  3. Ask for confirmation again

If we want to do the 3-step process, then what would we show differently to the modal on step (2)?

Copy link
Copy Markdown
Member

@matifali matifali Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I think @sreya should help us here on what would be best. IMO, changing the button is sufficient, but it would be best to validate with the end user who reported it.

Let's merge this as it is with a renamed button, and we can consider a 3rd prompt in a follow-up if needed.

Copy link
Copy Markdown
Member

@matifali matifali Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the issue open and update that we updated the button name

Copy link
Copy Markdown
Contributor

@sreya sreya Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think a 3rd prompt would really achieve anything. I thought for some reason we weren't prompting the user after they clicked update. The rename is sufficient imo,

Copy link
Copy Markdown
Member

@matifali matifali Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @EhabY we can close the issue now I think.

},
"Update",
"Update and Restart",
);
if (action === "Update") {
if (action === "Update and Restart") {
await this.remoteWorkspaceClient.updateWorkspaceVersion(this.workspace);
}
}
Expand Down