Handle concurrent binary downloads using file locks#656
Conversation
mafredri
left a comment
There was a problem hiding this comment.
I'm not against the file locking implementation used here, but asking out of curiosity: would IPC communication between VS Code windows have been an option here, like with the login prompt?
Thanks for working on this ❤️, concurrent downloads has been a pain-point for me!
@mafredri We could maybe use this for the progress monitoring but we definitely need a lock file since that would make crashes/staleness/stuck handling much simpler. Libraries like |
6d67d87 to
f6d76c8
Compare
mtojek
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments! As long as other reviewers approve, you're good to go 👍
mafredri
left a comment
There was a problem hiding this comment.
Nothing to add, thanks for amending/answering my comments 👍🏻
Closes #575