Add SSE fallback to some one way WS connections#623
Merged
EhabY merged 5 commits intocoder:mainfrom Oct 17, 2025
Merged
Conversation
EhabY
force-pushed
the
add-sse-fallback-to-ws
branch
from
352c38b to
bd3a0d8
Compare
EhabY
commented
Oct 14, 2025
mtojek
reviewed
Oct 15, 2025
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
I haven't looked into tests yet, but I can give a few observations now 👍
mtojek
approved these changes
Oct 15, 2025
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
LGTM, but I didn't dive too deep. I don't see anything concerning, but it might be feasible to ask @code-asher for another look.
Member
|
Sorry, did not get a chance to review, I can do it next Monday if we want another pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SSE fallback to some WS connections:
/api/v2/workspaces/${workspace.id}/watch-ws->/api/v2/workspaceagents/${agentId}/watch-metadata/api/v2/workspaceagents/${agentId}/watch-metadata-ws->/api/v2/workspaceagents/${agentId}/watch-metadataRestored the previous code regarding
createStreamingFetchAdapterto stream in SSE events.OneWayWebSocket.CoderApiCloses #620