fix: handle agent parameter in URIs

[ethanndickson]

This fixes a bug where the agent query parameter on the extension URI was ignored.

We were previously doing:

vscode.commands.executeCommand(
	"coder.openDevContainer",
	workspaceOwner,
	workspaceName,
	workspaceAgent,
	devContainerName,
	devContainerFolder,
);

where args[2] was the agent name, but we were discarding it:

const workspaceOwner = args[0] as string;
const workspaceName = args[1] as string;
const workspaceAgent = undefined; // args[2] is reserved, but we do not support multiple agents yet.
const devContainerName = args[3] as string;
const devContainerFolder = args[4] as string;

The same was true for the coder.open command. Presumably due to the comment saying multiple agents aren't supported, which hasn't been true for years.

[ethanndickson]

• fix: handle agent parameter in URIs #538 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ethanndickson]

openDevcontainer URIs must include the agent name to work properly, I believe, so this is string and not string | undefined.

[mafredri]

LGTM, thanks for fixing this!

[mafredri]

What's the purpose of this?

[ethanndickson]

We have the same file on coder/coder - it's just a convenient way to remove a formatting commit from git blame results. I noticed every line was blamed on #528. No longer the case after running git config blame.ignoreRevsFile .git-blame-ignore-revs

[ethanndickson]

Merge activity

• Jun 25, 1:25 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 25, 1:25 AM UTC: @ethanndickson merged this pull request with Graphite.