feat: handle windows specific paths in log-path parameter

[ibetitsmike]

Fixes: #430

[bcpeinhardt]

I suspect the issue was that claude nuked your lockfile (it likes to do that). Just reverting the lockfile fixed the build. I'll leave passing the test and lint checks up to you :)

[jaggederest]

This seems fine to me, but I am not yet competent to hand out the ✅ of approval so I've asked Asher to take a look 👍

[code-asher]

It seems like a reasonable change to me since we already use escapeCommandArg() on other path arguments. It would be nice to see a test for updateSSHConfig().

The issue says we are printing --log-dir C%3A%5CUsers%5Cmicha%5Clogs, so I assume now we will be printing --log-dir "C%3A%5CUsers%5Cmicha%5Clogs" which might work (or at least not error), but it seems like we should really be printing --log-dir "C:\Users\micha\logs".

Do we know where the escaped chars came from?

[code-asher]

Oh duh it was using escape before. Looks good to me. I do think we should test this stuff eventually.

[code-asher]

I know what happened, escapeCommandArg used to be called escape and was local to updateSSHConfig, then formatLogArg was broken out into its own function, with no access to the local escape, but escape happens to be a built-in function so no errors were thrown lol

[ibetitsmike]

Oh duh it was using escape before. Looks good to me. I do think we should test this stuff eventually.

@code-asher as in 'unit test'?

[code-asher]

Unit test would be ideal yeah! But I think updateSSHConfig() would need to be broken out of Remote. Might not be worth the effort right now, feel free to merge.