-
Notifications
You must be signed in to change notification settings - Fork 41
v3.0.0: Major improvements + new features #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 143 out of 155 changed files in this pull request and generated 1 comment.
Files not reviewed (12)
- android/src/main/AndroidManifest.xml: Language not supported
- android/src/main/res/xml/wallpaper.xml: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/codemodel-v2-bb5646173387af7ec5dc.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/directory-.-Debug-f5ebdc15457944623624.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/index-2025-04-14T11-41-39-0026.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCCompiler.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCXXCompiler.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeSystem.cmake: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/cmake.check_cache: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/rules.ninja: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build.json: Language not supported
- example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build_mini.json: Language not supported
Comments suppressed due to low confidence (2)
android/src/main/kotlin/com/codenameakshay/async_wallpaper/AsyncWallpaperPlugin.kt:63
- Consider cancelling the coroutineScope (e.g., invoking coroutineScope.cancel()) when detaching the plugin to prevent potential memory leaks.
override fun onDetachedFromEngine(@NonNull binding: FlutterPlugin.FlutterPluginBinding) {
android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java:121
- [nitpick] For consistency, consider using a dedicated TAG constant for logging throughout VideoLiveWallpaper.java instead of hard-coded strings like "VideoEngine" and "VideoLiveWallpaper".
Log.e("VideoEngine", "Error updating playback settings", e);
android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java
Outdated
Show resolved
Hide resolved
…LiveWallpaper.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Very nice I also suggest upgrading the gradle version to above gradle-8.2.1 because of some deprecation errors in the new Flutter version |
This pull request includes significant updates to the Android project, focusing on dependency upgrades, permission adjustments, and new features for battery management in the
VideoLiveWallpaperservice. The most important changes include upgrading the Android Gradle plugin, modifying permissions in the manifest, and implementing battery-aware playback settings.Dependency and build script updates:
android/build.gradle: Upgraded the Android Gradle plugin from version 7.2.0 to 7.4.2.example/android/app/build.gradle: Applied new plugins for Android application and Kotlin, updated Java version compatibility, and added new dependencies for desugaring and multidex support. [1] [2] [3] [4]example/android/build.gradle: Removed old buildscript and dependencies sections.Permission and manifest changes:
android/src/main/AndroidManifest.xml: Adjusted permissions for external storage withmaxSdkVersion, added new permissions for media access, and added a new service forVideoLiveWallpaper.Battery management and playback settings:
android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java: Introduced battery management to adjust video playback settings based on battery level, including reducing frame rate and playback speed in low battery mode. [1] [2]These changes collectively enhance the application's performance, compatibility, and user experience, particularly in scenarios involving low battery conditions.