Skip to content

Conversation

@codenameakshay
Copy link
Owner

@codenameakshay codenameakshay commented Apr 14, 2025

This pull request includes significant updates to the Android project, focusing on dependency upgrades, permission adjustments, and new features for battery management in the VideoLiveWallpaper service. The most important changes include upgrading the Android Gradle plugin, modifying permissions in the manifest, and implementing battery-aware playback settings.

Dependency and build script updates:

Permission and manifest changes:

  • android/src/main/AndroidManifest.xml: Adjusted permissions for external storage with maxSdkVersion, added new permissions for media access, and added a new service for VideoLiveWallpaper.

Battery management and playback settings:

These changes collectively enhance the application's performance, compatibility, and user experience, particularly in scenarios involving low battery conditions.

@codenameakshay codenameakshay requested a review from Copilot April 14, 2025 14:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 143 out of 155 changed files in this pull request and generated 1 comment.

Files not reviewed (12)
  • android/src/main/AndroidManifest.xml: Language not supported
  • android/src/main/res/xml/wallpaper.xml: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/codemodel-v2-bb5646173387af7ec5dc.json: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/directory-.-Debug-f5ebdc15457944623624.json: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/.cmake/api/v1/reply/index-2025-04-14T11-41-39-0026.json: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCCompiler.cmake: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeCXXCompiler.cmake: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/3.22.1-g37088a8/CMakeSystem.cmake: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/cmake.check_cache: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/CMakeFiles/rules.ninja: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build.json: Language not supported
  • example/android/app/.cxx/Debug/241v3r3n/arm64-v8a/android_gradle_build_mini.json: Language not supported
Comments suppressed due to low confidence (2)

android/src/main/kotlin/com/codenameakshay/async_wallpaper/AsyncWallpaperPlugin.kt:63

  • Consider cancelling the coroutineScope (e.g., invoking coroutineScope.cancel()) when detaching the plugin to prevent potential memory leaks.
override fun onDetachedFromEngine(@NonNull binding: FlutterPlugin.FlutterPluginBinding) {

android/src/main/java/com/codenameakshay/async_wallpaper/VideoLiveWallpaper.java:121

  • [nitpick] For consistency, consider using a dedicated TAG constant for logging throughout VideoLiveWallpaper.java instead of hard-coded strings like "VideoEngine" and "VideoLiveWallpaper".
Log.e("VideoEngine", "Error updating playback settings", e);

@codenameakshay codenameakshay self-assigned this Apr 15, 2025
@guyluz11
Copy link
Contributor

guyluz11 commented May 6, 2025

Very nice

I also suggest upgrading the gradle version to above gradle-8.2.1 because of some deprecation errors in the new Flutter version

$ flutter --version
Flutter 3.29.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision ea121f8859 (4 weeks ago) • 2025-04-11 19:10:07 +0000
Engine • revision cf56914b32
Tools • Dart 3.7.2 • DevTools 2.42.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants