Skip to content

WIP: bug fixes and lib updates #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rodgomesc wants to merge 8 commits into
base: master
Choose a base branch
from
Open

WIP: bug fixes and lib updates #19

rodgomesc wants to merge 8 commits into from

Conversation

@rodgomesc
Copy link
Collaborator

@rodgomesc rodgomesc commented Apr 13, 2024 •
edited
Loading

@rodgomesc rodgomesc requested a review from frmdstryr April 13, 2024 23:37
@rodgomesc rodgomesc self-assigned this Apr 13, 2024
@rodgomesc rodgomesc changed the title bug fixes and lib updates WIP: bug fixes and lib updates Apr 13, 2024
@rodgomesc rodgomesc force-pushed the fix/patch1 branch 3 times, most recently from d89e9a0 to 0fba631 Compare April 14, 2024 00:17
@frmdstryr
Copy link
Collaborator

frmdstryr commented Apr 14, 2024

Any idea why ci isn't running?

@rodgomesc
Copy link
Collaborator Author

rodgomesc commented Apr 14, 2024 •
edited
Loading

Any idea why ci isn't running?

don't know yet, i still need to to solve some building issues to get all libs working

i'll keep them updated here https://anaconda.org/rodgomesc/repo?type=all

just got panda partially building but it crashes after the first loop while changing archs :(

@rodgomesc
- update python compilation flags
4d595e8 
- update android cffi
- update adroid atom
@rodgomesc
chore: update kiwisover
63528a4
@rodgomesc
Copy link
Collaborator Author

rodgomesc commented Apr 25, 2024 •
edited
Loading

@frmdstryr is there by any chance you can help fixing the build of last version of enaml shared libs as you seem an active contributor of it, i already fixed all the deps enaml need for build, if we can chat on discord about that would be nice, i don't have much time available as well but i'll keep fixing things here as i do some experiments

my discord just in case: rodgomesc
edit1: created a discord server for conda-mobile --> https://discord.gg/DrAeCtXB

@frmdstryr
Copy link
Collaborator

frmdstryr commented Apr 26, 2024

Enaml changed to use a new parser for 3.11+. Instead of ply it uses pegen.

frmdstryr
frmdstryr reviewed Apr 26, 2024
View reviewed changes
android-enaml/build.sh

# Rename and move all so files to lib
cd build/lib.android-$ARCH-$PY_VER/
cd build/lib.android-$ARCH-cpython-310/
Copy link
Collaborator

@frmdstryr frmdstryr Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should use the export PY_LIB_VER_NODOTS=$(echo $PY_LIB_VER | tr -d '.') like you added in some of the other packages.

frmdstryr
frmdstryr reviewed Apr 26, 2024
View reviewed changes
android-enaml/build.sh
python setup.py develop

# Write parse tables
python $RECIPE_DIR/write_tables.py
Copy link
Collaborator

@frmdstryr frmdstryr Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed with the new parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frmdstryr frmdstryr frmdstryr left review comments

Assignees

@rodgomesc rodgomesc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodgomesc @frmdstryr